xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var pr

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var present
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Feb 2012 12:21:32 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <4F3AAA03.2010305@xxxxxxxxxx>
References: <4F3AAA03.2010305@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 14, 2012 at 10:37:55AM -0800, Eric Sandeen wrote:
> sendfile_f() calls openfile() with NULL *geom even if it's on an
> xfs filesystem, so we need to skip the ioctl if (!geom).
> 
> Fixes regression from d1b88183bb3fc5e338746db53269310348646753
> 
> Reported-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>