xfs
[Top] [All Lists]

Re: [PATCH] xfstests: more careful size grep in 256

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: more careful size grep in 256
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Feb 2012 12:21:10 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <4F3AA739.1000009@xxxxxxxxxx>
References: <4F3AA739.1000009@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 14, 2012 at 10:26:01AM -0800, Eric Sandeen wrote:
> Removing the "-F" flag in xfs_io changed stat output.
> 
> Before the change when -F was used, whether or not the file
> was on xfs, it skipped the extra FSGEOM call.  Now that -F is 
> removed, it calls FSGEOM if the file is on an xfs fs.  The "size" 
> grep in test 256 was a bit too loose and matched 2 lines if the
> FSGEOM output was present, breaking the test.
> 
> A more specific grep for stat.size fixes this.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>