xfs
[Top] [All Lists]

Re: [patch 03/12] xfs: remove xfs_trans_unlocked_item

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [patch 03/12] xfs: remove xfs_trans_unlocked_item
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 16 Feb 2012 12:51:47 -0600
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4F1D6F24.6050509@xxxxxxx>
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx> <20111212141433.885467482@xxxxxxxxxxxxxxxxxxxxxx> <4F1D6F24.6050509@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jan 23, 2012 at 08:31:00AM -0600, Mark Tinguely wrote:
> On 01/-10/63 13:59, Christoph Hellwig wrote:
>> There is no reason to wake up log space waiters when unlocking inodes or
>> dquots, and the commit log has no explanation for this function either.
>>
>> Given that we now have exact log space wakeups everywhere we can assume
>> to reason for this function was to paper over log space races in earlier
   the
>> XFS versions.
>>
>> Signed-off-by: Christoph Hellwig<hch@xxxxxx>
>
> I agree, these unlock won't change the amount of available log space.
>
> I did not find the exact reason for these original calls the the log  
> space wake routines.
>
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

I agree too.  Christoph's assessment that "the reason for this function was
to paper over log space races" seems spot on, and it's nice to get rid
of xfs_trans_unlocked_item.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [patch 03/12] xfs: remove xfs_trans_unlocked_item, Ben Myers <=