xfs
[Top] [All Lists]

Re: [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes r

To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Subject: Re: [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes reservations
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 14 Feb 2012 21:33:06 -0500
Cc: Ben Myers <bpm@xxxxxxx>, Alex Elder <aelder@xxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, yrl.pp-manager.tt@xxxxxxxxxxx
In-reply-to: <20120206125105.12624.93123.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20120206124951.12624.88233.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> <20120206125105.12624.93123.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 06, 2012 at 09:51:05PM +0900, Mitsuo Hayasaka wrote:
> This patch is a cleanup of quota check on disk blocks and inodes
> reservations, and changes it as follows.
> 
> (1) add a total_count variable to store the total number of
>     current usages and new reservations for disk blocks and inodes,
>     respectively.
> 
> (2) make it more readable to check if the local variables softlimit
>     and hardlimit are positive. It has been changed as follows.
>           if (softlimit > 0ULL) -> if (softlimit)
>           if (hardlimit > 0ULL) -> if (hardlimit)
>     This is because they are defined as xfs_qcnt_t which is unsigned.
> 
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
> Cc: Ben Myers <bpm@xxxxxxx>
> Cc: Alex Elder <elder@xxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>