| To: | xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] xfstests: more careful size grep in 256 |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Tue, 14 Feb 2012 10:26:01 -0800 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20120129 Thunderbird/10.0 |
Removing the "-F" flag in xfs_io changed stat output.
Before the change when -F was used, whether or not the file
was on xfs, it skipped the extra FSGEOM call. Now that -F is
removed, it calls FSGEOM if the file is on an xfs fs. The "size"
grep in test 256 was a bit too loose and matched 2 lines if the
FSGEOM output was present, breaking the test.
A more specific grep for stat.size fixes this.
Reported-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
diff --git a/256 b/256
index 283c7f2..ffe172a 100755
--- a/256
+++ b/256
@@ -98,7 +98,7 @@ _fill_fs() {
if [ -f $dir/$file_count.bin ]
then
- bytes_written=`$XFS_IO_PROG -F -c "stat"
$dir/$file_count.bin | grep size | cut -d ' ' -f3`
+ bytes_written=`$XFS_IO_PROG -F -c "stat"
$dir/$file_count.bin | grep stat.size | cut -d ' ' -f3`
fi
# If there was no room to make the file,
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: XFS unlink still slow on 3.1.9 kernel ?, Richard Ems |
|---|---|
| Next by Date: | [PATCH] xfsprogs: skip FSGEOMETRY call in openfile if no geom var present, Eric Sandeen |
| Previous by Thread: | xfsrestore will create orphanage directory when use -t, Tommy Wu |
| Next by Thread: | Re: [PATCH] xfstests: more careful size grep in 256, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |