[Top] [All Lists]

Re: [PATCH v2] xfsdump: use the full 32-bit generation number

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfsdump: use the full 32-bit generation number
From: Bill Kendall <wkendall@xxxxxxx>
Date: Mon, 13 Feb 2012 10:36:24 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120212234720.GA3848@xxxxxxxxxxxxx>
References: <1328813180-29095-1-git-send-email-wkendall@xxxxxxx> <20120212234720.GA3848@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20111108 Thunderbird/3.1.16
On 02/12/2012 05:47 PM, Christoph Hellwig wrote:
Looks generally good to me, but is there any good reason to not make
the -K argument extensible by requiring a version argument, even if
that one currently only supports 2 and 3 as valid values?

I thought about doing that, but given the low frequency of format
changes decided it could wait until there's more than one old format
to support. -K without an argument could be treated as "generate
the previous media format", or with an argument it could generate
a specific format. I'm okay with requiring a version argument though,
being explicit is better.

FWIW, the way things have always worked is that xfsrestore provides
backwards compatibility for all dump formats. xfsdump has, until
now, always generated the current format. It's nice to provide
the ability to generate old formats during a transition period,
but long-term I don't see xfsdump retaining support for generating
all old formats.


<Prev in Thread] Current Thread [Next in Thread>