xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix msync() call in fsx.c:domapwrite()

To: Curt Wohlgemuth <curtw@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix msync() call in fsx.c:domapwrite()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 12 Feb 2012 18:48:52 -0500
Cc: xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <1328642166-389-1-git-send-email-curtw@xxxxxxxxxx>
References: <1328642166-389-1-git-send-email-curtw@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 07, 2012 at 11:16:06AM -0800, Curt Wohlgemuth wrote:
> This explicitly sends MS_SYNC as the flag to msync() in
> fsx.c, in domapwrite().  Without this flag, the memory
> written to the mmap'ed region will not be flushed to disk;
> in fact, on Linux, calling msync() with a '0' or MS_ASYNC
> flag is a no-op.

Looks sensible to me - what exactly msync did has always been grossly
different for different operating systems, including changing meaning
on Linux a few times, so let's be explicit.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>