xfs
[Top] [All Lists]

Re: [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes r

To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Subject: Re: [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes reservations
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 10 Feb 2012 16:23:07 -0600
Cc: xfs@xxxxxxxxxxx, yrl.pp-manager.tt@xxxxxxxxxxx
In-reply-to: <20120206125105.12624.93123.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20120206124951.12624.88233.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> <20120206125105.12624.93123.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/06/12 06:51, Mitsuo Hayasaka wrote:
This patch is a cleanup of quota check on disk blocks and inodes
reservations, and changes it as follows.

(1) add a total_count variable to store the total number of
     current usages and new reservations for disk blocks and inodes,
     respectively.

(2) make it more readable to check if the local variables softlimit
     and hardlimit are positive. It has been changed as follows.
            if (softlimit>  0ULL) ->  if (softlimit)
            if (hardlimit>  0ULL) ->  if (hardlimit)
     This is because they are defined as xfs_qcnt_t which is unsigned.

Signed-off-by: Mitsuo Hayasaka<mitsuo.hayasaka.hu@xxxxxxxxxxx>


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>