xfs
[Top] [All Lists]

Re: [PATCH -v2 2/3] xfs: make inode quota check more general

To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Subject: Re: [PATCH -v2 2/3] xfs: make inode quota check more general
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 10 Feb 2012 15:32:06 -0600
Cc: xfs@xxxxxxxxxxx, yrl.pp-manager.tt@xxxxxxxxxxx
In-reply-to: <20120206125030.12624.95365.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20120206124951.12624.88233.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> <20120206125030.12624.95365.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/06/12 06:50, Mitsuo Hayasaka wrote:
The xfs checks quota when reserving disk blocks and inodes. In the block
reservation, it checks if the total number of blocks including current
usage and new reservation exceed quota. In the inode reservation,
it checks using the total number of inodes including only current usage
without new reservation. However, this inode quota check works well
since the caller of xfs_trans_dquot() always sets the argument of the
number of new inode reservation to 1 or 0 and inode is reserved one by
one in current xfs.

To make it more general, this patch changes it to the same way as the
block quota check.


Does not hurt to be consistent with the block reservations.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>