xfs
[Top] [All Lists]

Re: [PATCH] repair: fix incorrect use of thread local data in dir and at

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] repair: fix incorrect use of thread local data in dir and attr code
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 8 Feb 2012 15:13:53 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120207175400.GA24301@xxxxxxxxxxxxx>
References: <20120207175400.GA24301@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 07, 2012 at 12:54:00PM -0500, Christoph Hellwig wrote:
> The attribute and dirv1 code use pthread thread local data incorrectly in
> a few places, which will make them fail in horrible ways when using the
> ag_stride options.
> 
> Replace the use of thread local data with simple local allocations given
> that there is no needed to micro-optimize these allocations as much
> as e.g. the extent map.  The added benefit is that we have to allocate
> less memory, and can free it quickly.
> 
> Reported-by: Tom Crane <T.Crane@xxxxxxxxxx>
> Tested-by: Tom Crane <T.Crane@xxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks pretty sane to me. Especially as the comments suggest it never
even worked correctly in the first place.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>