[Top] [All Lists]

Re: [PATCH 3/3] filemap: don't call generic_write_sync for -EIOCBQUEUED

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] filemap: don't call generic_write_sync for -EIOCBQUEUED
From: Jeff Moyer <jmoyer@xxxxxxxxxx>
Date: Tue, 07 Feb 2012 15:39:06 -0500
Cc: Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20120206195546.GA22640@xxxxxxxxxxxxx> (Christoph Hellwig's message of "Mon, 6 Feb 2012 14:55:47 -0500")
References: <1327698949-12616-1-git-send-email-jmoyer@xxxxxxxxxx> <1327698949-12616-4-git-send-email-jmoyer@xxxxxxxxxx> <20120202175219.GB6640@xxxxxxxxxxxxx> <x497gzzrkfa.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120206195546.GA22640@xxxxxxxxxxxxx>
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)
Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> On Mon, Feb 06, 2012 at 11:33:29AM -0500, Jeff Moyer wrote:
>> > code, right? Before that we'd drain the IO queue when cache flush is issued
>> > and thus effectively wait for IO completion...
>> Right, though hch seems to think even then the problem existed.
> I was wrong, using -o barrier it didn't.  That was however not something
> people using O_SYNC heavy production loads would do, they'd use disabled
> caches and nobarrier.
>> > Also I was thinking whether we couldn't implement the fix in VFS. Basically
>> > it would be the same like the fix for ext4. Like having a per-sb workqueue
>> > and queue work calling generic_write_sync() from end_io handler when the
>> > file is O_SYNC? That would solve the issue for all filesystems...
>> Well, that would require buy-in from the other file system developers.
>> What do the XFS folks think?
> I don't think using that code for XFS makes sene.  But just like
> generic_write_sync there's no reason it can't be added to generic code,
> just make sure only generic_file_aio_write/__generic_file_aio_write use
> it, but generic_file_buffered_write and generic_file_direct_write stay
> clear of it.

ext4_file_write (ext4's .aio_write routine) calls into
generic_file_aio_write.  So, I don't think we can generalize that this
routine means that the file system doesn't install its own endio
handler.  What's more, we'd have to pass an endio routine down the call
stack quite a ways.  In all, I think that would be an uglier solution to
the problem.  Did I miss something?


<Prev in Thread] Current Thread [Next in Thread>