xfs
[Top] [All Lists]

Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer

To: Kevan Rehm <kfr@xxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 7 Feb 2012 13:38:30 -0500
In-reply-to: <20111113120133.GC19435@xxxxxxxxxxxxx>
References: <3ed89446f6dc1231ec1de712f242522052952b7e.1320955675.git.aelder@xxxxxxx> <6833e89ecf7daa3ba69676fb98a4538ee6c3a1b5.1320955675.git.aelder@xxxxxxx> <20111113120133.GC19435@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Nov 13, 2011 at 07:01:33AM -0500, Christoph Hellwig wrote:
> On Thu, Nov 10, 2011 at 02:35:13PM -0600, Alex Elder wrote:
> > From: Kevan Rehm <kfr@xxxxxxx>
> > 
> > In phase 6, in mk_root_dir(), xfs_repair initializes the mount
> > point's m_rootip pointer without accounting for that reference.
> > This field never really used or needed in repair otherwise, and the
> > assigned pointer doesn't really represent a real reference to an
> > inode that needs to be cached.  So just kill off this assignment.
> > 
> > Signed-off-by: Alex Elder <aelder@xxxxxxx>
> 
> Shouldn't this also have Kevan's signoff?

Kevan, can you give me a signoff for this patch, I'd like to put it in?

<Prev in Thread] Current Thread [Next in Thread>