[Top] [All Lists]

Re: [PATCH] Introduce SEEK_DATA/SEEK_HOLE support to XFS V7

To: jeff.liu@xxxxxxxxxx
Subject: Re: [PATCH] Introduce SEEK_DATA/SEEK_HOLE support to XFS V7
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 07 Feb 2012 08:19:24 -0600
Cc: xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>
In-reply-to: <4F2FE66C.80303@xxxxxxxxxx>
References: <4F2FE66C.80303@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/06/12 08:40, Jeff Liu wrote:

There is one bug fix in this version, in xfs_seek_data()/xfs_seek_hole(), call 
xfs_bmapi_read() or
xfs_bmap_first_unused() maybe failed, they should return ENXIO in this case.
Thanks Mark for pointing this out!

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>

  fs/xfs/xfs_file.c |  172 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
  1 files changed, 171 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 753ed9b..3822b15 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1141,8 +1141,178 @@ xfs_vm_page_mkwrite(
        return block_page_mkwrite(vma, vmf, xfs_get_blocks);

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>