[Top] [All Lists]

Re: [PATCH 0/7] better dquot caching

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/7] better dquot caching
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 7 Feb 2012 01:30:09 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120201135719.202171828@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120201135719.202171828@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
Hey Christoph,

On Wed, Feb 01, 2012 at 08:57:19AM -0500, Christoph Hellwig wrote:
> This series improves handling of large number of dquots.  It replaced
> the direct recycling of dquots from the freelist with a shrinker, removes
> the upper bound of dquots, and uses per-filesystem structures for all
> quota state, including switching from a hash to a radix-tree for lookups.
> For repeated lookups of dquots out of a large pool I see improvements
> betwen 50% and 500% compared to the previous code.  All these tests
> have been performed with Q_XQUOTASYNC already disabled as it would
> change the result to much for both the old and new code.
> Note that the first patch probably is a candidate for Linux 3.3, as
> the previous quota updates caused a lock order reversal in the old
> quota reclaim code.  See the actual patch for more details.

These conflict with Chandra's project quota patches.  I've started
looking at them again, but I am a little uncomfortable with the change
to the superblock...  could I get your opinion of that while I take a
look at these?


<Prev in Thread] Current Thread [Next in Thread>