xfs
[Top] [All Lists]

Re: [PATCH V2] xfsprogs: check for size parsing errors in xfs_quota

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfsprogs: check for size parsing errors in xfs_quota
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 03 Feb 2012 11:41:11 -0600
Cc: James Lawrie <james@xxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4F22FA5B.4030500@xxxxxxxxxxx>
References: <4F1D9989.8060808@xxxxxxxxxx> <20120124175612.GH9853@xxxxxxxxxxxxx> <4F22FA5B.4030500@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.24) Gecko/20111206 Thunderbird/3.1.16
On 01/27/12 13:26, Eric Sandeen wrote:
Doing something like

# xfs_quota -x -c 'limit -u bhard=1.2g ...

will cause cvtnum to fail and return a value of -1LL (because it
cannot parse the decimal), but the quota caller doesn't check
for this error value, casts it to U64, shifts right, and we end
up with an answer of 16 petabytes rather than erroring out.
Fix this.

Reported-by: James Lawrie<james@xxxxxxxxxxxxxx>
Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

Looks and works great.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH V2] xfsprogs: check for size parsing errors in xfs_quota, Mark Tinguely <=