| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_io: deprecate the "-F" foreign flag |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Fri, 03 Feb 2012 10:10:40 -0600 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20120203150443.GA28301@xxxxxxxxxxxxx> |
| References: | <4F2AC948.1050909@xxxxxxxxxx> <20120203150443.GA28301@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20120129 Thunderbird/10.0 |
On 2/3/12 9:04 AM, Christoph Hellwig wrote: > On Thu, Feb 02, 2012 at 11:35:04AM -0600, Eric Sandeen wrote: >> There's no real reason to force the user to specify "-F" for non-xfs >> files, when we can just test for that after it's opened. >> >> * Remove the -F flag from usage() & man pages, but still accept it. >> * Set IO_FOREIGN when we open the file, if the fd tests as non-xfs. > > Looks good. We probably should kill the IO_FOREIGN eventually too, but > let's do the user facing part first. How would you want to handle non-xfs filesystems in the xfs-specific commands? Do the fd test each time? > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks, I'll merge it. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC PATCH 1/4] Define a new function xfs_this_quota_on(), Ben Myers |
|---|---|
| Next by Date: | Re: [RFC PATCH 2/4] Define a new function xfs_inode_dquot(), Ben Myers |
| Previous by Thread: | Re: [PATCH] xfs_io: deprecate the "-F" foreign flag, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfs_io: deprecate the "-F" foreign flag, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |