xfs
[Top] [All Lists]

Re: [RFC PATCH 1/4] Define a new function xfs_this_quota_on()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [RFC PATCH 1/4] Define a new function xfs_this_quota_on()
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 3 Feb 2012 09:19:58 -0600
Cc: Chandra Seetharaman <sekharan@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120124174712.GD9853@xxxxxxxxxxxxx>
References: <20120123173118.31546.3353.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120123173125.31546.2342.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120124174712.GD9853@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Jan 24, 2012 at 12:47:12PM -0500, Christoph Hellwig wrote:
> On Mon, Jan 23, 2012 at 11:31:25AM -0600, Chandra Seetharaman wrote:
> > Create a new function xfs_this_quota_on() that takes a xfs_mount
> > data srtucture and a disk quota type and returns true if the specified
> > type of quota is ON in the xfs_mount data structure.
> > 
> > Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>
> 
> Looks good except for a tiny style nitpick.
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> > +   switch(type) {
> 
> This should have a whitespace after the opening brace.

I've added the space.

This patch looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [RFC PATCH 1/4] Define a new function xfs_this_quota_on(), Ben Myers <=