| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_io: deprecate the "-F" foreign flag |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 3 Feb 2012 10:04:43 -0500 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| In-reply-to: | <4F2AC948.1050909@xxxxxxxxxx> |
| References: | <4F2AC948.1050909@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Feb 02, 2012 at 11:35:04AM -0600, Eric Sandeen wrote: > There's no real reason to force the user to specify "-F" for non-xfs > files, when we can just test for that after it's opened. > > * Remove the -F flag from usage() & man pages, but still accept it. > * Set IO_FOREIGN when we open the file, if the fd tests as non-xfs. Looks good. We probably should kill the IO_FOREIGN eventually too, but let's do the user facing part first. Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Placing the root partition on an XFS filesystem is not supported, Marcos Mello |
|---|---|
| Next by Date: | Re: [RFC PATCH 1/4] Define a new function xfs_this_quota_on(), Ben Myers |
| Previous by Thread: | [PATCH] xfs_io: deprecate the "-F" foreign flag, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfs_io: deprecate the "-F" foreign flag, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |