xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfs: cleanup quota check on disk blocks and inodes reser

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfs: cleanup quota check on disk blocks and inodes reservations
From: HAYASAKA Mitsuo <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Date: Fri, 03 Feb 2012 13:05:57 +0900
Cc: Ben Myers <bpm@xxxxxxx>, Alex Elder <aelder@xxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx
In-reply-to: <20120202160726.GA10568@xxxxxxxxxxxxx>
References: <20120123034513.3339.97432.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> <20120123034543.3339.56848.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> <20120202160726.GA10568@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111105 Thunderbird/8.0
Hi Christoph

Thank you for your comments.

(2012/02/03 1:07), Christoph Hellwig wrote:
> On Mon, Jan 23, 2012 at 12:45:43PM +0900, Mitsuo Hayasaka wrote:
>> This patch is a cleanup of quota check on disk blocks and inodes
>> reservations.
>>
>> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
>> Cc: Ben Myers <bpm@xxxxxxx>
>> Cc: Alex Elder <elder@xxxxxxxxxx>
>> Cc: Christoph Hellwig <hch@xxxxxx>
>> ---
>>
>>  fs/xfs/xfs_trans_dquot.c |   17 +++++++----------
>>  1 files changed, 7 insertions(+), 10 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
>> index c4ba366..5e6cd1c 100644
>> --- a/fs/xfs/xfs_trans_dquot.c
>> +++ b/fs/xfs/xfs_trans_dquot.c
>> @@ -605,7 +605,7 @@ xfs_trans_dqresv(
>>      time_t          timer;
>>      xfs_qwarncnt_t  warns;
>>      xfs_qwarncnt_t  warnlimit;
>> -    xfs_qcnt_t      count;
>> +    xfs_qcnt_t      tcount;
> 
> Can you call this variable total_count to make it a bit more obvious?

Sure.

> 
>> +                    tcount = *resbcountp + nblks;
>> +                    if (hardlimit > 0ULL && tcount > hardlimit) {
> 
> Given that xfs_qcnt_t is unsigned what about transforming this into the
> more readable:
> 
>                       if (hardlimit && total_count > hardlimit)
> 
> and similar for the others?
> 

OK, I'm going to change them and send the revised patch series.

Thanks.

<Prev in Thread] Current Thread [Next in Thread>