| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] repair: update extent count after zapping duplicate blocks |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Thu, 02 Feb 2012 12:19:19 -0600 |
| Cc: | Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20120202123910.GA8708@xxxxxxxxxxxxx> |
| References: | <20111202174619.179530033@xxxxxxxxxxxxxxxxxxxxxx> <20111202174741.904845954@xxxxxxxxxxxxxxxxxxxxxx> <20111213021207.GY14273@dastard> <20120202123910.GA8708@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.24) Gecko/20111206 Thunderbird/3.1.16 |
On 02/02/12 06:39, Christoph Hellwig wrote: When we find a duplicate extent in an extern format inode we do not zap the whole inode, but just truncate it to the point where the duplicate extent was found. But the current code only updates di_nblocks for the new size, but no di_nextents/di_anextents. In most cases this isn't noticed, but when moving such an inode to the lost+found directoy the consistency check in xfs_iformat trips over it. Fix this by updating the on-disk extent count as part of the inode repair. Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 0/3] include reservations in quota reporting, Jan Kara |
|---|---|
| Next by Date: | Re: Placing the root partition on an XFS filesystem is not supported, Eric Sandeen |
| Previous by Thread: | [PATCH v2] repair: update extent count after zapping duplicate blocks, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 3/3] xfs: cleanup quota check on disk blocks and inodes reservations, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |