[Top] [All Lists]

Re: Trailing garbage in event tracing output

To: Brian Candler <B.Candler@xxxxxxxxx>
Subject: Re: Trailing garbage in event tracing output
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 2 Feb 2012 09:09:47 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120202115211.GA1259@xxxxxxxx>
References: <20120202115211.GA1259@xxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 02, 2012 at 11:52:11AM +0000, Brian Candler wrote:
> Just a minor issue, but when I did some XFS tracing using the instructions
> at http://lwn.net/Articles/341899/ I found that there was trailing garbage
> in the filenames logged in xfs_lookup.  Example:

> (where I think the real filename was "000000295aSl688"). I would guess the
> logger is expecting null-terminated strings but they aren't.

That's indeed the case.  See the attched patch to fix the issue.  To
apply it against the 3.0 kernel you'll probably have to edit it to
remove "linux-2.6/" directory in the filenames.

Attachment: xfs-fix-filename-tracing
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>