xfs
[Top] [All Lists]

Trailing garbage in event tracing output

To: xfs@xxxxxxxxxxx
Subject: Trailing garbage in event tracing output
From: Brian Candler <B.Candler@xxxxxxxxx>
Date: Thu, 2 Feb 2012 11:52:11 +0000
Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=date:from:to :subject:message-id:mime-version:content-type; s=sasl; bh=tjBpmd kVutSU0kfrkXTJ7HqQ5Jg=; b=QiX+sdtV0req5Eevugteyc5nfvBK5ekIioaLAK MMHmIGG7cH8XLqeJeaEWMsfat5ofdOvndaOls1oc2LvoKjkCeq4aTP8AFLkiQtw2 MyTYY2fk4h6TK/vJM6dyqiH5cKKBtQDSg/OTeQwoFDT4C79lYxaV1nA3uH1GE/j3 t0oIU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=pobox.com; h=date:from:to :subject:message-id:mime-version:content-type; q=dns; s=sasl; b= sxfV3AmNDyKJXWt8mQBCSphFQbRXrM/jSEy+GoOrShJH9ZUtzKO7AbUA4ckfgPp4 ACBYlUqVmClZsY8YgMLPBtzFEo7O/V564hmUSfeevB1+HqCAAl5+rGHJ9nZS5w1w v/2W+/bLcWJ6e32Z+jlupci4aG3SdVcjwaBeMJYd5nk=
User-agent: Mutt/1.5.21 (2010-09-15)
Just a minor issue, but when I did some XFS tracing using the instructions
at http://lwn.net/Articles/341899/ I found that there was trailing garbage
in the filenames logged in xfs_lookup.  Example:

...
        bonnie++-26179 [000] 322388.834204: xfs_iunlock: dev 8:32 ino 0xfe1e6 
flags ILOCK_SHARED caller xfs_free_eofblocks
        bonnie++-26179 [000] 322388.834212: xfs_lookup: dev 8:32 dp ino 0xfb50d 
name 000000295aSl688>v??*N
        bonnie++-26179 [000] 322388.834213: xfs_ilock: dev 8:32 ino 0xfb50d 
flags ILOCK_SHARED caller xfs_ilock_map_shared
...

(where I think the real filename was "000000295aSl688"). I would guess the
logger is expecting null-terminated strings but they aren't.

This is with the stock kernel from Ubuntu 11.10 server x86_64:
Linux storage1 3.0.0-15-server #26-Ubuntu SMP Fri Jan 20 19:07:39 UTC 2012 
x86_64 x86_64 x86_64 GNU/Linux

Regards,

Brian.

<Prev in Thread] Current Thread [Next in Thread>