xfs
[Top] [All Lists]

Re: [patch] xfs: remove an unneeded NULL check

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [patch] xfs: remove an unneeded NULL check
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 1 Feb 2012 05:45:01 -0500
Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20120131225601.GQ9090@dastard>
References: <20120128105501.GB25092@xxxxxxxxxxxxxx> <20120131225601.GQ9090@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Feb 01, 2012 at 09:56:01AM +1100, Dave Chinner wrote:
> >     /* lock out background commit */
> >     down_read(&log->l_cilp->xc_ctx_lock);
> > -   if (commit_lsn)
> > -           *commit_lsn = log->l_cilp->xc_ctx->sequence;
> > +   *commit_lsn = log->l_cilp->xc_ctx->sequence;
> >  
> >     xlog_cil_insert_items(log, log_vector, tp->t_ticket);
> 
> There's a set of reviewed patches (for 3.3) that change all this
> code. The null check might still be there, but that needs to be
> checked.

Which series is that?  I mut have to admit I've lost track by now.

<Prev in Thread] Current Thread [Next in Thread>