xfs
[Top] [All Lists]

[NOTES] [patch] xfs: remove an unneeded NULL check

To: xfs@xxxxxxxxxxx
Subject: [NOTES] [patch] xfs: remove an unneeded NULL check
From: Phil White <pwhite@xxxxxxx>
Date: Tue, 31 Jan 2012 14:04:56 -0800
In-reply-to: <20120128105501.GB25092@xxxxxxxxxxxxxx>
References: <20120128105501.GB25092@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
#pwhite: We can safely remove this check because the one call to
#xfs_log_commit_cil() comes from xfs_trans_commit() and passes a pointer to a
#local variable.

Smatch complains because we check "commit_lsn" for NULL inconsistently.
fs/xfs/xfs_log_cil.c +705 xfs_log_commit_cil(43) error: we previously
        assumed 'commit_lsn' could be null (see line 688)
xfs_log_commit_cil() is only called from one place, and "commit_lsn" is
a valid pointer, so I've removed the NULL check.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Phil White <pwhite@xxxxxxx>

diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
index d4fadbe..d9c4652 100644
--- a/fs/xfs/xfs_log_cil.c
+++ b/fs/xfs/xfs_log_cil.c
@@ -685,8 +685,7 @@ xfs_log_commit_cil(
 
        /* lock out background commit */
        down_read(&log->l_cilp->xc_ctx_lock);
-       if (commit_lsn)
-               *commit_lsn = log->l_cilp->xc_ctx->sequence;
+       *commit_lsn = log->l_cilp->xc_ctx->sequence;
 
        xlog_cil_insert_items(log, log_vector, tp->t_ticket);

<Prev in Thread] Current Thread [Next in Thread>