xfs
[Top] [All Lists]

Question on xfstest 274

To: wu.bo@xxxxxxxxxxxxxx, xfs-oss <xfs@xxxxxxxxxxx>
Subject: Question on xfstest 274
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 27 Jan 2012 14:51:46 -0600
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1
Hi, I was wondering if you could describe your intent for 274 just a little 
more.

The test says:

# preallocation test

but that is the only comment other than copyright.  ;)

I see that it does:

# Make a 1G fs
# Create a single 4k file
# Allocate 1M past the EOF on that file
# Completely fill remaining space, using 2 other files
# Write 8k past EOF on the original file which has blocks past EOF

but I am not certain what you are testing.  I presume that
you are testing the fact that the 1M past EOF should be truncated,
freeing up space, and allowing the 8k write to succeed?
Is that right?

However, at least on ext4 I noticed that the "fill the fs"
stage does not succeed; perhaps that should be tested as well.

I can do some similar work on this like I did for 275, but I need
to be sure I understand your original intent for the test, first.

Thanks,
-Eric

<Prev in Thread] Current Thread [Next in Thread>