xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: Sort recursive getfattr output in 062

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests: Sort recursive getfattr output in 062
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 27 Jan 2012 05:53:45 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, Andreas Dilger <adilger@xxxxxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>, Yu Jian <yujian@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4F20766E.9040902@xxxxxxxxxxx>
References: <4EC10664.1080501@xxxxxxxxxxxx> <CAO47_-9nfO32nwOAQMVdqw6iWGWK+FWb+MD=WeOz_vr4YrrKmw@xxxxxxxxxxxxxx> <20111115142246.GA7516@xxxxxxxxx> <246EA1CC-3C33-4D41-80C0-2331C426EBB0@xxxxxxxxxxxxx> <4ECA4282.5020908@xxxxxxxxxxxxx> <401CC4FF-8955-4D5F-B620-5C39AF566123@xxxxxxx> <4ECB2ADE.3010007@xxxxxxxxxx> <4ECD28D1.1080800@xxxxxxxxxx> <4F20766E.9040902@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 25, 2012 at 03:38:54PM -0600, Eric Sandeen wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Test 062 was made "generic" a while back, but it fails on any filesystem
> which returns getfattr -R results (aka readdir results) in something
> other than inode-order.
> 
> With a little awk-fu we can sort the records from getfattr -R so that
> the output is the same for xfs as well as ext4, etc.
> 
> Also filter out lost+found which extN creates at mkfs time, but
> some other filesystems do not.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> - ---
> 
> V2: move sorting function into common.attr

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>