[Top] [All Lists]

Re: [patch 04/12] xfs: cleanup xfs_log_space_wake

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [patch 04/12] xfs: cleanup xfs_log_space_wake
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 25 Jan 2012 11:10:41 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4F1DB36E.3060207@xxxxxxx>
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx> <20111212141434.065702206@xxxxxxxxxxxxxxxxxxxxxx> <4F1DB36E.3060207@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jan 23, 2012 at 01:22:22PM -0600, Mark Tinguely wrote:
> On 01/-10/63 13:59, Christoph Hellwig wrote:
> >Remove the now unused opportunistic parameter, and use the the
> >xlog_writeq_wake and xlog_reserveq_wake helpers now that we don't have
> >to care about the opportunistic wakeups.
> >
> >Signed-off-by: Christoph Hellwig<hch@xxxxxx>
> Looks good. My only concern is the way that xlog_grant_push_ail()
> tries to kick start the writing of the log. It seems to me that a
> combination of very large log requests could plug the log until the
> next sync.

How exactly?

<Prev in Thread] Current Thread [Next in Thread>