xfs
[Top] [All Lists]

Re: [patch 01/12] xfs: split tail_lsn assignments from log space wakeups

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [patch 01/12] xfs: split tail_lsn assignments from log space wakeups
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 25 Jan 2012 11:09:25 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4F15C26A.30408@xxxxxxx>
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx> <20111212141433.542846138@xxxxxxxxxxxxxxxxxxxxxx> <4F15C26A.30408@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jan 17, 2012 at 12:48:10PM -0600, Mark Tinguely wrote:
> On 01/-10/63 13:59, Christoph Hellwig wrote:
> >Currently xfs_log_move_tail has a tail_lsn argument that is horribly
> >overloaded: it may contain either an actual lsn to assign to the log tail,
> >0 as a special case to use the last sync LSN, or 1 to indicate that no tail
> >LSN assignment should be performed, and we should opportunisticly wake up
> >at least one task waiting for log space.
> 
> I read the code as opportunistically waking at MOST one task per call.

I guess my wording wasn't quite clear - the opportunistic flag makes
sure at least one task is woken per call, but at most one of them
wouldn't otherwise be woken.

> Looks great. Just to be consistent, you could call the above as:
> 
> +             xfs_log_space_wake(ailp->xa_mount, true);

Indeed.

<Prev in Thread] Current Thread [Next in Thread>