xfs
[Top] [All Lists]

Re: [RFC PATCH 2/4] Define a new function xfs_inode_dquot()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [RFC PATCH 2/4] Define a new function xfs_inode_dquot()
From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Date: Tue, 24 Jan 2012 13:41:36 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120124174850.GE9853@xxxxxxxxxxxxx>
Organization: IBM
References: <20120123173118.31546.3353.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120123173130.31546.80744.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120124174850.GE9853@xxxxxxxxxxxxx>
Reply-to: sekharan@xxxxxxxxxx
On Tue, 2012-01-24 at 12:48 -0500, Christoph Hellwig wrote:
> On Mon, Jan 23, 2012 at 11:31:30AM -0600, Chandra Seetharaman wrote:
> > Define a new function xfs_inode_dquot() that takes a inode pointer
> > and a disk quota type and returns the quota pointer for the specified
> > quota type.
> > 
> > This simplifies the xfs_qm_dqget() error path significantly.
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
> > +static inline xfs_dquot_t *xfs_inode_dquot(struct xfs_inode *ip, int type)
> > +{
> > +   type &= XFS_DQ_ALLTYPES;
> > +   switch(type) {
> 
> Same style nitpick as for the last patch.
> 
> Btw, instead of masking out XFS_DQ_ALLTYPES first this would be more
> readable as:
> 
>       switch (type & XFS_DQ_ALLTYPES) {
> 
> (that also applies to the previous patch).
> 

Will fix both of these in the next version.

Thanks for the review Christoph.

Chandra


<Prev in Thread] Current Thread [Next in Thread>