xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: check for size parsing errors in xfs_quota

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: check for size parsing errors in xfs_quota
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 24 Jan 2012 12:56:12 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, James Lawrie <james@xxxxxxxxxxxxxx>
In-reply-to: <4F1D9989.8060808@xxxxxxxxxx>
References: <4F1D9989.8060808@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> -             v = (__uint64_t)cvtnum(blocksize, sectorsize, s);
> -             *value = v >> 9;        /* syscalls use basic blocks */
> +             v = cvtnum(blocksize, sectorsize, s);
> +             if (v == -1LL) {
> +                     fprintf(stderr, _("%s: Error: could not parse size 
> %s.\n"), progname, s);
> +                     return 0;
> +             }
> +             *value = (__uint64_t)v >> 8;    /* syscalls use basic blocks */

Why do you replace the shift by nine with a shift by 8?

Also please don't introduce new overly long lines, just move the
translated string to a line of its own, indented by a single tab similar
to how we do it in most new xfs/xfsprogs code.

<Prev in Thread] Current Thread [Next in Thread>