xfs
[Top] [All Lists]

Re: [RFC PATCH 2/4] Define a new function xfs_inode_dquot()

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [RFC PATCH 2/4] Define a new function xfs_inode_dquot()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 24 Jan 2012 12:48:50 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120123173130.31546.80744.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20120123173118.31546.3353.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120123173130.31546.80744.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jan 23, 2012 at 11:31:30AM -0600, Chandra Seetharaman wrote:
> Define a new function xfs_inode_dquot() that takes a inode pointer
> and a disk quota type and returns the quota pointer for the specified
> quota type.
> 
> This simplifies the xfs_qm_dqget() error path significantly.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> +static inline xfs_dquot_t *xfs_inode_dquot(struct xfs_inode *ip, int type)
> +{
> +     type &= XFS_DQ_ALLTYPES;
> +     switch(type) {

Same style nitpick as for the last patch.

Btw, instead of masking out XFS_DQ_ALLTYPES first this would be more
readable as:

        switch (type & XFS_DQ_ALLTYPES) {

(that also applies to the previous patch).

<Prev in Thread] Current Thread [Next in Thread>