xfs
[Top] [All Lists]

Re: [patch 07/12] xfs: add xlog_grant_head_init

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 07/12] xfs: add xlog_grant_head_init
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 24 Jan 2012 09:43:12 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111212141434.689066888@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx> <20111212141434.689066888@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.24) Gecko/20111206 Thunderbird/3.1.16
On 01/-10/63 13:59, Christoph Hellwig wrote:
---
  fs/xfs/xfs_log.c |   18 ++++++++++++------
  1 file changed, 12 insertions(+), 6 deletions(-)

Index: xfs/fs/xfs/xfs_log.c
===================================================================
--- xfs.orig/fs/xfs/xfs_log.c   2011-12-11 21:24:39.502740565 +0100
+++ xfs/fs/xfs/xfs_log.c        2011-12-11 21:28:15.334904636 +0100
@@ -150,6 +150,15 @@ xlog_grant_add_space(
        } while (head_val != old);
  }

+STATIC void
+xlog_grant_head_init(
+       struct xlog_grant_head  *head)
+{
+       xlog_assign_grant_head(&head->grant, 1, 0);
+       INIT_LIST_HEAD(&head->waiters);
+       spin_lock_init(&head->lock);
+}
+

...

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [patch 07/12] xfs: add xlog_grant_head_init, Mark Tinguely <=