[Top] [All Lists]

Re: [patch 04/12] xfs: cleanup xfs_log_space_wake

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 04/12] xfs: cleanup xfs_log_space_wake
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 23 Jan 2012 13:22:22 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111212141434.065702206@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx> <20111212141434.065702206@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv: Gecko/20111206 Thunderbird/3.1.16
On 01/-10/63 13:59, Christoph Hellwig wrote:
Remove the now unused opportunistic parameter, and use the the
xlog_writeq_wake and xlog_reserveq_wake helpers now that we don't have
to care about the opportunistic wakeups.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Looks good. My only concern is the way that xlog_grant_push_ail() tries to kick start the writing of the log. It seems to me that a combination of very large log requests could plug the log until the next sync. I am not sure if that is why the opportunistic wakeups were put in or not. If this is an issue, there are better ways than opportunistic wakeups in the unlock code (patch3 xfs: remove xfs_trans_unlocked_item).

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>