xfs
[Top] [All Lists]

Re: [patch 03/12] xfs: remove xfs_trans_unlocked_item

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 03/12] xfs: remove xfs_trans_unlocked_item
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 23 Jan 2012 08:31:00 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111212141433.885467482@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx> <20111212141433.885467482@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.24) Gecko/20111206 Thunderbird/3.1.16
On 01/-10/63 13:59, Christoph Hellwig wrote:
There is no reason to wake up log space waiters when unlocking inodes or
dquots, and the commit log has no explanation for this function either.

Given that we now have exact log space wakeups everywhere we can assume
to reason for this function was to paper over log space races in earlier
XFS versions.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

I agree, these unlock won't change the amount of available log space.

I did not find the exact reason for these original calls the the log space wake routines.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [patch 03/12] xfs: remove xfs_trans_unlocked_item, Mark Tinguely <=