[Top] [All Lists]

Re: [patch 02/12] xfs: do exact log space wakeups in xlog_ungrant_log_sp

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 02/12] xfs: do exact log space wakeups in xlog_ungrant_log_space
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 17 Jan 2012 16:42:33 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111212141433.714245384@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx> <20111212141433.714245384@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv: Gecko/20111206 Thunderbird/3.1.16
On 01/-10/63 13:59, Christoph Hellwig wrote:
The only reason that xfs_log_space_wake had to do opportunistic wakeups
was that the old xfs_log_move_tail calling convention didn't allow for
exact wakeups when not updating the log tail LSN.  Since this issue has
been fixed we can do exact wakeups now.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

  fs/xfs/xfs_log.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: xfs/fs/xfs/xfs_log.c
--- xfs.orig/fs/xfs/xfs_log.c   2011-12-11 15:30:49.977750776 +0100
+++ xfs/fs/xfs/xfs_log.c        2011-12-11 17:49:00.692836117 +0100
@@ -2748,7 +2748,7 @@ xlog_ungrant_log_space(xlog_t          *log,

        trace_xfs_log_ungrant_exit(log, ticket);

-       xfs_log_space_wake(log->l_mp, true);
+       xfs_log_space_wake(log->l_mp, false);


It make sense that xlog_ungrant_log_space() does not need to do opportunistic wakeup.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [patch 02/12] xfs: do exact log space wakeups in xlog_ungrant_log_space, Mark Tinguely <=