xfs
[Top] [All Lists]

Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid
From: HAYASAKA Mitsuo <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Date: Fri, 13 Jan 2012 11:46:52 +0900
Cc: Ben Myers <bpm@xxxxxxx>, Alex Elder <aelder@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, yrl.pp-manager.tt@xxxxxxxxxxx
In-reply-to: <20120112161410.GA3810@xxxxxxxxxxxxx>
References: <20120112024720.3952.73517.stgit@xxxxxxxxxxxxxxxxxxxxxxxx> <20120112161410.GA3810@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111105 Thunderbird/8.0
Hi Christoph,

Thank you for your comment.

(2012/01/13 1:14), Christoph Hellwig wrote:
> On Thu, Jan 12, 2012 at 11:47:20AM +0900, Mitsuo Hayasaka wrote:
>> When a system tries to mount a filesystem (FS) using UUID, the xfs
>> returns -EINVAL and shows a message if a FS with the same UUID has
>> been already mounted. It is useful to output the duplicate UUID
>> with it.
> 
> Looks good to me,
> 
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
>> -    xfs_warn(mp, "Filesystem has duplicate UUID - can't mount");
>> +    xfs_warn(mp,
>> +            "Filesystem has duplicate UUID - can't mount: uuid = %pU",
>> +            uuid);
> 
> Maybe we could write this a bit nicer as:
> 
>       xfs_warn(mp, "Filesystem has duplicate UUID %p - can't mount", uuid);
> 

It looks nice.
I will send the revised patch soon.

Thanks.

<Prev in Thread] Current Thread [Next in Thread>