xfs
[Top] [All Lists]

Re: [PATCH 02/12] repair: allocate and free inode records individually

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/12] repair: allocate and free inode records individually
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 12 Jan 2012 16:38:50 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111202174741.284403190@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111202174619.179530033@xxxxxxxxxxxxxxxxxxxxxx> <20111202174741.284403190@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.24) Gecko/20111206 Thunderbird/3.1.16
On 01/-10/63 13:59, Christoph Hellwig wrote:
Instead of allocating inode records in chunks and keeping a freelist of them
which never gets released to the system memory allocator use plain malloc
and free for them.  The freelist just means adding a global lock instead
of relying on malloc and free which could be implemented lockless, and the
freelist is almost completely worthless as we are done allocating new
inode records once we start freeing them in major quantities.


Looks good. Has been running without issues.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 02/12] repair: allocate and free inode records individually, Mark Tinguely <=