[Top] [All Lists]

Re: [PATCH 12/12] repair: cleanup inode record macros

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/12] repair: cleanup inode record macros
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 12 Jan 2012 11:05:32 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120111113020.GD10932@xxxxxxxxxxxxx>
References: <20111202174619.179530033@xxxxxxxxxxxxxxxxxxxxxx> <20111202174743.697687824@xxxxxxxxxxxxxxxxxxxxxx> <20120111113020.GD10932@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv: Gecko/20111206 Thunderbird/3.1.16
On 01/11/12 05:30, Christoph Hellwig wrote:

On Fri, Dec 02, 2011 at 12:46:31PM -0500, Christoph Hellwig wrote:
Remove indirections in the inode record bit manipulation macros and flatten
them to a single level of inlines.  Also use a common IREC_MASK define
instead of duplicating it for every bitmask.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

The clean up looks good. I like the removal of the side effect that was in one of the ASSERT statement.

--Mark Tinguely

<Prev in Thread] Current Thread [Next in Thread>