xfs
[Top] [All Lists]

Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid

To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@xxxxxxxxxxx>
Subject: Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 12 Jan 2012 11:14:10 -0500
Cc: Ben Myers <bpm@xxxxxxx>, Alex Elder <aelder@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, yrl.pp-manager.tt@xxxxxxxxxxx
In-reply-to: <20120112024720.3952.73517.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20120112024720.3952.73517.stgit@xxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jan 12, 2012 at 11:47:20AM +0900, Mitsuo Hayasaka wrote:
> When a system tries to mount a filesystem (FS) using UUID, the xfs
> returns -EINVAL and shows a message if a FS with the same UUID has
> been already mounted. It is useful to output the duplicate UUID
> with it.

Looks good to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> -     xfs_warn(mp, "Filesystem has duplicate UUID - can't mount");
> +     xfs_warn(mp,
> +             "Filesystem has duplicate UUID - can't mount: uuid = %pU",
> +             uuid);

Maybe we could write this a bit nicer as:

        xfs_warn(mp, "Filesystem has duplicate UUID %p - can't mount", uuid);

<Prev in Thread] Current Thread [Next in Thread>