| To: | Alex Elder <elder@xxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink() |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Wed, 11 Jan 2012 19:52:10 +0100 |
| Cc: | xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>, Jan Kara <jack@xxxxxxx>, stable@xxxxxxxxxx, Carlos Maiolino <cmaiolino@xxxxxxxxxx> |
Commit b52a360b forgot to call xfs_iunlock() when it detected corrupted
symplink and bailed out. Fix it by jumping to 'out' instead of doing return.
CC: stable@xxxxxxxxxx
CC: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Signed-off-by: Jan Kara <jack@xxxxxxx>
---
fs/xfs/xfs_vnodeops.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c
index f2fea86..6156cd6 100644
--- a/fs/xfs/xfs_vnodeops.c
+++ b/fs/xfs/xfs_vnodeops.c
@@ -131,7 +131,8 @@ xfs_readlink(
__func__, (unsigned long long) ip->i_ino,
(long long) pathlen);
ASSERT(0);
- return XFS_ERROR(EFSCORRUPTED);
+ error = XFS_ERROR(EFSCORRUPTED);
+ goto out;
}
--
1.7.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Empty dir can't be removed ... because it's not empty?, Rafa GrimÃn |
|---|---|
| Next by Date: | Re: [PATCH] xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink(), Ben Myers |
| Previous by Thread: | Query, Anshul Kundra |
| Next by Thread: | Re: [PATCH] xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink(), Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |