xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix 251's cp -axT problem

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix 251's cp -axT problem
From: Lukas Czerner <lczerner@xxxxxxxxxx>
Date: Wed, 11 Jan 2012 13:14:29 +0100 (CET)
Cc: Liu Bo <liubo2009@xxxxxxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Lukas Czerner <lczerner@xxxxxxxxxx>
In-reply-to: <20120111114544.GE14423@xxxxxxxxxxxxx>
References: <1326195560-4434-1-git-send-email-liubo2009@xxxxxxxxxxxxxx> <20120111114544.GE14423@xxxxxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Wed, 11 Jan 2012, Christoph Hellwig wrote:

> On Tue, Jan 10, 2012 at 07:39:20PM +0800, Liu Bo wrote:
> > When I ran xfstests, 251 got failed cause "cp -axT" did not work as wish:
> > cp: cannot overwrite directory `/mnt/scratch/1' with non-directory
> > 
> > With this patch, 251 has passed.
> 
> Why would cp give that message with a missing /?
> 
> I'm not against putting this in, but I'd like to understand what's going
> on.
> 
> Lukas, any idea?
> 

Hi Christoph,

the only reason I can think of is probably that Liu is accessing the
xfstests directory via symbolic link, hence the '$content' addresses the
symbolic link and cp is trying to overwrite the directory with
non-directory (symlink).

The fix is fine for both cases (xfstests as symlink and directory), confirmed
with a simple test.

Thanks!
-Lukas

<Prev in Thread] Current Thread [Next in Thread>