Re: [PATCH] xfstests 271: use xfs_io to truncate file instead of truncat

xfs

Re: [PATCH] xfstests 271: use xfs_io to truncate file instead of truncat

To:	Eryu Guan <guaneryu@xxxxxxxxx>
Subject:	Re: [PATCH] xfstests 271: use xfs_io to truncate file instead of truncate(1)
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 11 Jan 2012 06:46:03 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1326213469-22687-1-git-send-email-guaneryu@xxxxxxxxx>
References:	<1326213469-22687-1-git-send-email-guaneryu@xxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Jan 11, 2012 at 12:37:48AM +0800, Eryu Guan wrote:
> Distros(eg. RHEL5) with older version of coreutils have no truncate(1)
> command. Use xfs_io instead to avoid "command not found" failures.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfstests 271: use xfs_io to truncate file instead of truncate(1), Eryu Guan [PATCH] xfstests 273: Create lost+found to pass _check_scratch_fs, Eryu Guan Re: [PATCH] xfstests 273: Create lost+found to pass _check_scratch_fs, Dave Chinner Re: [PATCH] xfstests 273: Create lost+found to pass _check_scratch_fs, Eryu Guan Re: [PATCH] xfstests 271: use xfs_io to truncate file instead of truncate(1), Christoph Hellwig <=

Previous by Date:	Re: [PATCH] xfstests: fix 251's cp -axT problem, Christoph Hellwig
Next by Date:	Re: [PATCH] xfstests: fix 251's cp -axT problem, Lukas Czerner
Previous by Thread:	Re: [PATCH] xfstests 273: Create lost+found to pass _check_scratch_fs, Eryu Guan
Next by Thread:	Re: bug: xfs_repair becomes very slow when file system has a large sparse file, Joe Landman
Indexes:	[Date] [Thread] [Top] [All Lists]