xfs
[Top] [All Lists]

Re: Why does xfsdump encounter "WARNING: could not get list of non-root

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"?
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 11 Jan 2012 05:29:49 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Michael Lueck <mlueck@xxxxxxxxxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <20120111101426.GI24410@dastard>
References: <jdo01m$62j$1@xxxxxxxxxxxxxxx> <20120102213706.GQ23662@dastard> <20120111095513.GA26958@xxxxxxxxxxxxx> <20120111100316.GH24410@dastard> <20120111100412.GA1538@xxxxxxxxxxxxx> <20120111101426.GI24410@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 11, 2012 at 09:14:27PM +1100, Dave Chinner wrote:
> Which has lead to several implementations of duplicated
> functionality like:
> 
>       - ext4_kvmalloc/ext4_kvfree
>       - drm_malloc_ab/drm_calloc_large/drm_free_large
>       - ceph_buffer_new/ceph_buffer_release
>       - gfs2_alloc_sort_buffer/gfs2_free_sort_buffer
>       - __ntfs_malloc/ntfs_free
> 
> I don't think adding another two sets of identical wrappers (or open
> coding it) is the right thing given that it is a repeating pattern.

Give it a try, I'm not against it myself.

<Prev in Thread] Current Thread [Next in Thread>