xfs
[Top] [All Lists]

Re: Why does xfsdump encounter "WARNING: could not get list of non-root

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"?
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 11 Jan 2012 21:14:27 +1100
Cc: Michael Lueck <mlueck@xxxxxxxxxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <20120111100412.GA1538@xxxxxxxxxxxxx>
References: <jdo01m$62j$1@xxxxxxxxxxxxxxx> <20120102213706.GQ23662@dastard> <20120111095513.GA26958@xxxxxxxxxxxxx> <20120111100316.GH24410@dastard> <20120111100412.GA1538@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 11, 2012 at 05:04:12AM -0500, Christoph Hellwig wrote:
> On Wed, Jan 11, 2012 at 09:03:16PM +1100, Dave Chinner wrote:
> > Sounds like a generic kvmalloc()/kvfree() call pair is the answer
> > then. i.e. if kmalloc fails, then use vmalloc()...
> 
> If my memory serves me right that's been discussed and rejected a few
> times before.

Which has lead to several implementations of duplicated
functionality like:

        - ext4_kvmalloc/ext4_kvfree
        - drm_malloc_ab/drm_calloc_large/drm_free_large
        - ceph_buffer_new/ceph_buffer_release
        - gfs2_alloc_sort_buffer/gfs2_free_sort_buffer
        - __ntfs_malloc/ntfs_free

I don't think adding another two sets of identical wrappers (or open
coding it) is the right thing given that it is a repeating pattern.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>