xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add SEEK_DATA/SEEK_HOLE sanity checker

To: jeff.liu@xxxxxxxxxx
Subject: Re: [PATCH] xfstests: add SEEK_DATA/SEEK_HOLE sanity checker
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 06 Jan 2012 09:54:29 -0600
Cc: xfs@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>
In-reply-to: <4EFB1C8D.8070405@xxxxxxxxxx>
References: <4EFB1C8D.8070405@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.24) Gecko/20111206 Thunderbird/3.1.16
On 12/28/11 07:41, Jeff Liu wrote:

+
+static ssize_t do_pwrite(int fd, const void *buf, size_t count, off_t
offset)
+{
+       ssize_t ret, written = 0;
+
+       while (count>  written) {
+               ret = pwrite(fd, buf + written, count - written, offset
+ written);



I believe there is a missing "-" between "offset" and "written".

The patchworks version (3108) was truncated.

There are some line wraps on the patch file, which give patch/quilt errors.

Minor text editing.

--Mark Tinguely.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfstests: add SEEK_DATA/SEEK_HOLE sanity checker, Mark Tinguely <=