xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 6 Jan 2012 09:38:35 -0600
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120106151254.GA11417@xxxxxxxxxxxxx>
References: <1324426062-21505-1-git-send-email-david@xxxxxxxxxxxxx> <1324426062-21505-3-git-send-email-david@xxxxxxxxxxxxx> <20111221043638.GR29840@xxxxxxx> <20120106151254.GA11417@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Jan 06, 2012 at 10:12:54AM -0500, Christoph Hellwig wrote:
> On Tue, Dec 20, 2011 at 10:36:38PM -0600, Ben Myers wrote:
> > On Wed, Dec 21, 2011 at 11:07:42AM +1100, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > > 
> > > When finding the longest extent in an AG, we read the value directly
> > > out of the AGF buffer without endian conversion. This will give an
> > > incorrect length, resulting in FITRIM operations potentially not
> > > trimming everything that it should.
> > 
> > Looks good to me.
> > 
> > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Reviewed-by: Ben Myers <bpm@xxxxxxx>
> 
> This is a pretty serious thing, can you send it to Linus as soon as
> he takes the current pull request?

yep.

<Prev in Thread] Current Thread [Next in Thread>