xfs
[Top] [All Lists]

Re: [PATCH] update 068 to reproduce an unfreeze hanging up problem

To: Masayoshi MIZUMA <m.mizuma@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] update 068 to reproduce an unfreeze hanging up problem
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 4 Jan 2012 09:59:44 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20111214112209.1002.61FB500B@xxxxxxxxxxxxxx>
References: <20111213094245.4004.61FB500B@xxxxxxxxxxxxxx> <20111213063212.GC14273@dastard> <20111214112209.1002.61FB500B@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 14, 2011 at 11:22:10AM +0900, Masayoshi MIZUMA wrote:
> > test 068 will catch problems like the one your specific test
> > catches, but maybe not every time. Test 068 will catch problems your
> > test case won't, though - it's a trade-off between having lots of
> > tests that are similar but slightly different (difficult to
> > maintain, increases runtime, etc), and having one test that
> > exercises the functionality in a simple manner likely to detect
> > problems.
> 
> Thank you for your explanation about the policy and I understand it.


> I tried to reproduce the problem not dropping the sleep, but the problem was
> not reproduced... Therefore, I dropped it and the problem was reproduced.
> 
> However, as you mentioned, the problem is a timing proglem, so the
> my reproduction might be just by chance. Dropping sleep may increase
> the possibility of the reproduction, but not every time, so the change
> is not good. That is same for the arguments of fsstress which I changed.
> 
> OK, I update 068 just to run other filesystem, ext3, ext4 and btrfs which
> I confirmed xfs_freeze works on.
> (xfs_freeze may work on the other filesystems which have freeze_fs/unfreeze_fs
>  super_operations but I don't confirm...)
> 
> The patch is below.

Given that MIZUMAs patch reproduces a real life issue I think adding
his original patch in addition to this change would be a good idea.

Dave, do you have a strong opinion against that?

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] update 068 to reproduce an unfreeze hanging up problem, Christoph Hellwig <=