[Top] [All Lists]

Re: [PATCH 2/2 v2] xfs: log all dirty inodes in xfs_fs_sync_fs

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 2/2 v2] xfs: log all dirty inodes in xfs_fs_sync_fs
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 26 Dec 2011 23:13:02 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Paul Anderson <pha@xxxxxxxxx>, Sean Thomas Caron <scaron@xxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111223214703.GW29840@xxxxxxx>
References: <20111218154936.GA17626@xxxxxxxxxxxxx> <20111218155015.GC17626@xxxxxxxxxxxxx> <20111220200841.GA2788@xxxxxxxxxxxxx> <20111223214703.GW29840@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Dec 23, 2011 at 03:47:03PM -0600, Ben Myers wrote:
> Reviewed-by: Ben Myers <bpm@xxxxxxx>
> Mark also reviewed this.
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

Just a process note here: if Mark reviewed the code and is happy
with it, then he needs to send his reviewed-by tag himself. If he's
got concerns, then he needs to discuss them on the list with the
patch author, not just in private with you. If a person's questions
are not posted to the mailing list or posted by proxy and they
didn't aprticipate in discussions on the list, then there is no
evidence that the person ever reviewed the patch. Hence the tag has
no value because it is not verifiable.

More importantly, tags are a semi-formal statement that a set of
actions has been taken by that person - see
Documentation/SubmittingPatches for the actions different tags
imply. Hence it is important the actions they imply are verifiable,
and it also reinforces the fact that they only have value when they
are issued by the email address (or a known alias) in the tag....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>