xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 20 Dec 2011 22:36:38 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1324426062-21505-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1324426062-21505-1-git-send-email-david@xxxxxxxxxxxxx> <1324426062-21505-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Dec 21, 2011 at 11:07:42AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When finding the longest extent in an AG, we read the value directly
> out of the AGF buffer without endian conversion. This will give an
> incorrect length, resulting in FITRIM operations potentially not
> trimming everything that it should.

Looks good to me.

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>