xfs
[Top] [All Lists]

Re: xfsprogs patches pw 2883, 2986-2997

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: xfsprogs patches pw 2883, 2986-2997
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 20 Dec 2011 13:33:43 +1100
Cc: hch@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <4EEFC18F.4020705@xxxxxxx>
References: <4EEFC18F.4020705@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 19, 2011 at 04:58:23PM -0600, Mark Tinguely wrote:
> Just a FYI to let you know that I testing your xfsprog patches that
> you submitted on Dec 2. I looked at the comments and the patches.
> The xfstests running now.
> 
> Dave Chinner had feedback requests on a couple items.

Yes, but Christoph has already replied so all I'm waiting on is a
repost of the series from him addressing those comments. He did say
it might take a while as he had other more critical stuff to do.

> Below is my summary of the patches:

I'd prefer it if you don't send emails this way - there's no context
to your comments about each patch. I'd have to go to a web browser
to start patchworks and look up some random index number and read
stuff before coming back to my email to comment sanely. That's way
to much stuffing about for me to bother - there's no way I can chew
through a couple of thousand emails a day with that sort of
workflow.

It is much better to reply in line to each of the patch emails with
your comments.  It is easy to understand the context of your
comments, you don't need to summarise all the patches (just reply to
ones you have comments about), and it fits the workflow we use for
tracking such comments (like patchworks). It also helps finding all
the discussion about a patch series in the mail archives. If you've
got a general comment about a series (like this email), reply to the
zero patch (the summary email).

Realistically, patchworks is just a tool to help the maintainer -
Ben - keep track of stuff if he requires help. It was set up because
Alex found it useful for this purpose, but if Ben doesn't need it
then it's probably not going to be maintained. Ben can weigh in on
this, though.....

FWIW, we talk quite a bit about bugs, patches, review and dev work
in #xfs (there's 50 people in the channel at the moment), so what
you see on the mailing list is often not the entire picture. There's
a lot more day to day dev stuff go on there -  what you see on the
mailing list is often the end result of something that was first
discussed on #xfs. :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>